Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous copy #1025

Closed
wants to merge 1 commit into from
Closed

Remove superfluous copy #1025

wants to merge 1 commit into from
+0 −3

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Sep 26, 2023

Not needed anymore since rancher/elemental-toolkit#1832

@frelon frelon requested a review from a team as a code owner September 26, 2023 11:18
@frelon frelon enabled auto-merge (squash) September 26, 2023 11:31
davidcassany
davidcassany approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, even we probably can drop this dockerfile in the near future

@frelon
Remove superfluous copy
ed325d3 
Signed-off-by: Fredrik Lönnegren <[email protected]>
@frelon
Copy link
Contributor Author

frelon commented Sep 27, 2023

Hmm, looking at the tests we will have to do a new release of the toolkit. I can revisit this when we get there 👍

@frelon frelon closed this Sep 27, 2023
auto-merge was automatically disabled September 27, 2023 11:54

Pull request was closed

@frelon frelon deleted the small-fix branch September 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany davidcassany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frelon @davidcassany